Fix TestStoreGateway_InitialSyncWithWaitRingStability flakyness #4305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
TestStoreGateway_InitialSyncWithWaitRingStability
is flaky and fails with this error:We've experienced a similar issue CASing the in-memory consul in the test
TestShuffleShardWithCaching
and, at that time, we solved it increasing retries and adding a delay between retries. Getting back toTestStoreGateway_InitialSyncWithWaitRingStability
, I'm able to reproduce the issue locally inmaster
but I can't reproduce it after this PR's change 🤞Which issue(s) this PR fixes:
Fixes #4290
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]