-
Notifications
You must be signed in to change notification settings - Fork 820
Implementing Zone aware sharding for alert manager #4204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Zone aware sharding for alert manager #4204
Conversation
b2cff7a
to
f57b2b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I think this is a really useful feature to have, without adding too much complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job and nice test! I left few nits, but overall LGTM. We can merge as soon as nits are fixed. Thanks a lot! 🙏
Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Steve Simpson <steve.simpson@grafana.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Steve Simpson <steve.simpson@grafana.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
8eeed47
to
d4e6410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the test - looks very nice.
All looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, otherwise LGTM.
@alanprot Feel free to ping me after you address my comments and I while approve/merge this PR
Co-authored-by: Jacob Lisi <jlisi@grafana.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Jacob Lisi <jlisi@grafana.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Jacob Lisi <jlisi@grafana.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
4083cc5
to
03ec992
Compare
Signed-off-by: Alan Protasio <approtas@amazon.com>
Thanks @jtlisi Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Implements Zone Aware sharding for alert manager.
With this option on, the alerts for a given tenant will be replicated across availability zones.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]