Skip to content

Implementing Zone aware sharding for alert manager #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alanprot
Copy link
Member

What this PR does:
Implements Zone Aware sharding for alert manager.
With this option on, the alerts for a given tenant will be replicated across availability zones.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot force-pushed the feature/zone-awaraness-alert-manager branch from b2cff7a to f57b2b7 Compare May 20, 2021 02:42
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I think this is a really useful feature to have, without adding too much complexity.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job and nice test! I left few nits, but overall LGTM. We can merge as soon as nits are fixed. Thanks a lot! 🙏

alanprot and others added 4 commits May 20, 2021 07:00
Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot force-pushed the feature/zone-awaraness-alert-manager branch from 8eeed47 to d4e6410 Compare May 20, 2021 14:00
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the test - looks very nice.

All looks good to me.

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, otherwise LGTM.

@alanprot Feel free to ping me after you address my comments and I while approve/merge this PR

alanprot and others added 3 commits May 24, 2021 17:26
Co-authored-by: Jacob Lisi <jlisi@grafana.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Jacob Lisi <jlisi@grafana.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Co-authored-by: Jacob Lisi <jlisi@grafana.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot force-pushed the feature/zone-awaraness-alert-manager branch from 4083cc5 to 03ec992 Compare May 25, 2021 00:26
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot
Copy link
Member Author

Thanks @jtlisi
I updated the PR with your comments!

Thanks

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 68048b7 into cortexproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants