Skip to content

RFC: Add integration test for etcd #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

ChinYing-Li
Copy link
Contributor

What this PR does:
Adds one integration test for etcd.
Signatures of six functions used in the integration tests had been changed.
I believe we should also test compactor, store gateway and ruler that use etcd as ring backend (hence the signature of NewRuler, NewCompactor etc. should also be modified), but I'd like to have some early feedback before moving forward.

Questions:

  1. Currently, in the backward compatibility tests, only consul is used. Shall backward compatibility test cases for etcd be added as well?

Which issue(s) this PR fixes:
Fixes #2137

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ChinYing-Li ChinYing-Li changed the title Add integration test for etcd RFC: Add integration test for etcd Apr 25, 2021
@pstibrany
Copy link
Contributor

Can you please take a look at failed linter checks? https://github.com/cortexproject/cortex/pull/4113/checks?check_run_id=2431082044

Thank you!

@ChinYing-Li
Copy link
Contributor Author

One irrelevant test is failing; do we need to kick the CI again?

@ChinYing-Li
Copy link
Contributor Author

@pstibrany A gentle ping; A test that seems irrelevant fails. Thanks!

@pstibrany
Copy link
Contributor

I don't seem to be able to restart checks here, not sure why. Can you try to push empty commit to your branch instead? That will trigger new run of checks. Thanks!

Signed-off-by: ChinYing-Li <chinying.li@mail.utoronto.ca>
@ChinYing-Li
Copy link
Contributor Author

ChinYing-Li commented Jun 5, 2021

The integration test fails in CI probably because I have changed the signature of several New* functions in integration/e2ecortex/service.go, and those changes are not in the build in the docker image used for CI.
The documentation says that the PR code is build in the image, and the integration test succeeds on my machine.
I will investigate why it's failing CI.
Updates:
Now I've resolved the CI failure, PR ready for review. Thank you, and any suggestion is appreciated.
@pstibrany

Signed-off-by: ChinYing-Li <chinying.li@mail.utoronto.ca>
@ChinYing-Li
Copy link
Contributor Author

PR ready for review, and any suggestion is appreciated! @pstibrany

@stale
Copy link

stale bot commented Sep 8, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 8, 2021
@bboreham
Copy link
Contributor

Thanks for the PR; sorry it has sat around such a long time.
The "chunks" storage has been deprecated, so this test would be deleted at some point.
Can it be modified to use "blocks" storage?

@stale stale bot removed the stale label Sep 16, 2021
Signed-off-by: ChinYing-Li <chinying.li@mail.utoronto.ca>
@ChinYing-Li
Copy link
Contributor Author

Hi, sorry for getting back late; was a bit tied down by the recruiting season. I have introduced the integration/block_storage_backends_test.go, which contains one test case.
Any suggestion is appreciated!

@ChinYing-Li
Copy link
Contributor Author

@bboreham Just a ping to let you know I've updated the PR to use block storage. Thank you!

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have packaged up store RingStore, address string into a struct to reduce the boilerplate at all call-sites, but it's fine as-is.
Thanks!

@alvinlin123 alvinlin123 merged commit 0ce5791 into cortexproject:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for cassandra, bigtable and etcd
4 participants