Add minimal support for missing routes in alertmanager distributor. #4084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft while I fix the tests. |
Add and test the following routes:
- `POST /alertmanager/api/v1/silences`
- `GET /alertmanager/api/v1/silences`
- `GET /alertmanager/api/v1/silence/{id}`
- `DELETE /alertmanager/api/v1/silence/{id}`
- `GET /alertmanager/api/v1/status`
- `POST /alertmanager/api/v1/receivers`
All requests are simply forwarded to a single randomly chosen replica
which is assigned for the shard which contains the user.
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
pstibrany
approved these changes
Apr 16, 2021
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
pracucci
approved these changes
Apr 16, 2021
Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add and test the following routes to the alertmanager distributor (in use only when sharding is enabled):
POST /alertmanager/api/v1/silencesGET /alertmanager/api/v1/silencesGET /alertmanager/api/v1/silence/{id}DELETE /alertmanager/api/v1/silence/{id}GET /alertmanager/api/v1/statusPOST /alertmanager/api/v1/receiversAll requests are simply forwarded to a single randomly chosen replica
of the shard which contains the user.
Note I've had to incorporate the fix from #4083 in this PR.Rebased.Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]