Refactoring: use PrefixedBucketClient in UserBucketClient #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Feb 24, 2021
| @@ -23,7 +22,7 @@ func NewPrefixedBucketClient(bucket objstore.Bucket, prefix string) *PrefixedBuc | |||
| } | |||
|
|
|||
| func (b *PrefixedBucketClient) fullName(name string) string { | |||
| return path.Join(b.prefix, name) | |||
| return b.prefix + objstore.DirDelim + name | |||
There was a problem hiding this comment.
To keep the same exact logic we had in UserBucketClient. If name is "", the delimiter must be added anyway.
There was a problem hiding this comment.
I see, sorry I made this change.
There was a problem hiding this comment.
Based on my suggestion, so sorry about that :)
I'm not sure empty name should be a valid choice though and I wonder how do object stores work in that case.
There was a problem hiding this comment.
I'm not sure empty name should be a valid choice
It's used to list the root. Thanos does it.
There was a problem hiding this comment.
Ah right, I misunderstood and was thinking about empty prefix.
pstibrany
approved these changes
Feb 24, 2021
pracucci
deleted the
use-prefixed-bucket-client-in-user-bucket-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is just an internal refactoring PR to use
PrefixedBucketClientinUserBucketClient.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]