Removed deprecated -querier.split-queries-by-day #3813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Feb 12, 2021
CharlieTLe
added a commit
that referenced
this pull request
Dec 24, 2024
...interval` Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813
CharlieTLe
added a commit
to CharlieTLe/cortex
that referenced
this pull request
Dec 24, 2024
...interval` Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. cortexproject#3813 Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
added a commit
that referenced
this pull request
Dec 24, 2024
...interval` Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813 Signed-off-by: Charlie Le <charlie_le@apple.com>
friedrichg
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Update arguments.md Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144 Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com> Signed-off-by: Charlie Le <charlie_le@apple.com> * Rename `-querier.split-queries-by-day` to `-querier.split-queries-by-... ...interval` Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813 Signed-off-by: Charlie Le <charlie_le@apple.com> * Fix typo and add description for `max_samples_per_query` Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal. Signed-off-by: Charlie Le <charlie_le@apple.com> * Remove 'Storage' section from arguments documentation Removed in 73567bc#diff-ed3c6bb08ff3f85373c673fd92d1429599243584fc46d51a3221782263f26821L130 Signed-off-by: Charlie Le <charlie_le@apple.com> * Update arguments.md * Remove deprecated flag Signed-off-by: Charlie Le <charlie_le@apple.com> --------- Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com> Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We deprecated
-querier.split-queries-by-dayin Cortex 0.4.0 but we never removed it. I guess it's time to do it.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]