Add more TSDB metrics for ingester to emit #3800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
pstibrany
approved these changes
Feb 9, 2021
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
force-pushed
the
more-tsdb-metrics
branch
from
6266ce1 to
94882c9
Compare
pstibrany
reviewed
Feb 9, 2021
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alvin Lin alvinlin@amazon.com
What this PR does:
This PR update the ingester to emit some metrics defined in TSDB's db.go.
I did not emit compaction related metrics because ingester already emit compaction metrics (
prometheus_tsdb_compactions_totalandprometheus_tsdb_compaction_duration_seconds) from TSDB's compactor, which is enough to get an over view of the compaction status.For
prometheus_tsdb_symbol_table_size_bytesandprometheus_tsdb_storage_blocks_bytesI decided to emit per user metric because it can help to identify "top talker" and react accordingly.Which issue(s) this PR fixes:
Fixes #3799
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]