feat: Emit per-tenant limit overrides as metrics #3785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
commented
Feb 3, 2021
56quarters
commented
Feb 3, 2021
Add a new target (not enabled as part of "all") that can be used to expose per-tenant limit overrides as Prometheus metrics. These metrics are updated as runtime configuration is periodically reloaded. Exposing these metrics enables use cases like proactively alerting when tenants start to approach their limits, instead of letting them hit their limits and start to lose data. Fixes #1433 See also #2957 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
pstibrany
reviewed
Feb 5, 2021
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
commented
Feb 8, 2021
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a new target (not enabled as part of "all") that can be used to
expose per-tenant limit overrides as Prometheus metrics. These metrics
are updated as runtime configuration is periodically reloaded.
Exposing these metrics enables use cases like proactively alerting when
tenants start to approach their limits, instead of letting them hit their
limits and start to lose data.
Which issue(s) this PR fixes:
Fixes #1433
See also #2957
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com