Enable @ modifier with result cache handling #3744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
codesome
force-pushed
the
enable-at-modifier
branch
from
234da3a to
23b3f25
Compare
|
Should we keep |
It is disabled by default in Prometheus because it has no in-built caching and so that users of PromQL can enable when they have fixed the caching to use this modifier. Since we handle the caching inside Cortex itself, I don't think we need to have a flag for that and just enable it by default. |
added 2 commits
January 26, 2021 13:53
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
|
After some offline discussions, I have added a flag for @ modifier. |
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
added 2 commits
January 31, 2021 18:34
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
gouthamve
approved these changes
Feb 2, 2021
pracucci
reviewed
Feb 2, 2021
| } | ||
| expr, err := parser.ParseExpr(query) | ||
| if err != nil { | ||
| // We are being pessimistic in such cases. |
There was a problem hiding this comment.
A warning log may be useful here. WDYT?
There was a problem hiding this comment.
I will open another PR for the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enables the newly added @ modifier in PromQL with cache handling for it.
If the time in @ is > query end time, then we don't cache the result. If @ time is <= end, then we cache, since even if the start and end were actually in the future we would end up caching the result anyway.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]