Upgrade Prometheus #3739
Merged
Upgrade Prometheus #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
commented
Jan 25, 2021
| @@ -74,6 +74,8 @@ replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110 | |||
|
|
|||
| replace k8s.io/client-go => k8s.io/client-go v0.19.2 | |||
|
|
|||
| replace k8s.io/api => k8s.io/api v0.19.4 | |||
There was a problem hiding this comment.
This is not used in any Cortex or vendored packages. It was actually used in tests of vendored package (Prometheus), so this replace should be safe (version was picked from what was present in go.sum).
|
Gave updated packages a quick glance, nothing breaking Cortex |
codesome
force-pushed
the
upgrade-prom
branch
from
96972c0 to
697c4b6
Compare
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
codesome
force-pushed
the
upgrade-prom
branch
from
697c4b6 to
8161b8c
Compare
pstibrany
approved these changes
Jan 25, 2021
|
|
|
Bug is in creation of blocks in |
|
It is (most likely) because of prometheus/prometheus#8212. I have pushed a fix. |
codesome
force-pushed
the
upgrade-prom
branch
from
8620570 to
dd4c988
Compare
pracucci
approved these changes
Jan 25, 2021
added 2 commits
January 25, 2021 19:25
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrades Prometheus to the lastest master commit b5dfa2414b9e65a275caad29c4023290d841c9ba.
This brings in the
@modifier in PromQL. It is disabled by default and I plan to submit a follow-up PR enabling it with cache handling for it.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]