Alertmanager: Remove alertmanager instead of pausing #3722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
changed the title
gotjosh
force-pushed
the
remove-alertmanager-instead-of-pausing
branch
from
fff6eaa to
c7964e9
Compare
pstibrany
reviewed
Jan 21, 2021
gotjosh
force-pushed
the
remove-alertmanager-instead-of-pausing
branch
from
c7964e9 to
fd36a58
Compare
|
One more Look @pstibrany? 🙏 |
Signed-off-by: gotjosh <josue@grafana.com>
Signed-off-by: gotjosh <josue@grafana.com>
Signed-off-by: gotjosh <josue@grafana.com>
Signed-off-by: gotjosh <josue@grafana.com>
Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
remove-alertmanager-instead-of-pausing
branch
from
fd36a58 to
dea78ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Completely removes a tenant's Alertmanagers when synchronising configurations.
Before, we would "pause" the Alertmanager which would never free up the resources, and leave the Alertmanager running in-memory.
I've also bundled a small change to a logger in the ruler that was double-logging the userID.
Which issue(s) this PR fixes:
NA/NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]