Fail to startup Cortex if provided runtime config is invalid #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gouthamve
approved these changes
Jan 18, 2021
Disagree. |
|
The removal of an error check on startup happens here: 870fe73#diff-f7e299904986266ff7106a24f1f542c4cab3fc980a401e416ab714627ba6585aL56-L58 |
|
Fixes #3031 |
👍 You're right. In that case I don't think there is any disagreement that we should merge this. |
gouthamve
pushed a commit
to grafana/cortex
that referenced
this pull request
Jan 25, 2021
…roject#3707) Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, Cortex can successfully startup if the provided runtime config (typically limits overrides) is invalid. We recently had an incident because of this: we rolled out ingesters with an invalid runtime config, ingesters start up correctly, but overrides were missing causing an impact on customers. Other alerts fired pretty soon, so the impact of the incident was limited.
As a retrospective, I believe we should fast fail Cortex at startup if the provided runtime config is invalid. For example, in the case of a rolling update, ingesters would stop to rollout until fixed.
I haven't changed the behaviour of an invalid config loaded while Cortex is running because, in that case, we keep the previous config and we definitely don't want to shutdown all ingesters because of this.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]