HA tracker limits #3668
Merged
HA tracker limits #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Jan 12, 2021
jtlisi
reviewed
Jan 15, 2021
pracucci
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Thanks @pstibrany for addressing my feedback. Overall LGTM, but I left few last comments.
CHANGELOG.md
Outdated
| @@ -39,6 +39,7 @@ | |||
| * [CHANGE] Ruler: gRPC message size default limits on the Ruler-client side have changed: #3523 | |||
| - limit for outgoing gRPC messages has changed from 2147483647 to 16777216 bytes | |||
| - limit for incoming gRPC messages has changed from 4194304 to 104857600 bytes | |||
| * [CHANGE] HA Tracker: verify label value limit for replica label. #3668 | |||
There was a problem hiding this comment.
Suggested change
| * [CHANGE] HA Tracker: verify label value limit for replica label. #3668 | |
| * [CHANGE] HA Tracker: verify label value length limit (`-validation.max-length-label-value`) for replica label. #3668 |
There was a problem hiding this comment.
Done. I've also moved entry to "master" section, somehow it was in 1.6 :)
pracucci
approved these changes
Jan 15, 2021
Oh, sorry I missed that! Thanks for review, I’ll fix the changelog before merging. |
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
…alidation fails. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR verifies that replica label isn't larger than configured max label value limit, and also introduces new limit for maximum number of clusters tracked by HA tracker.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]