-
Notifications
You must be signed in to change notification settings - Fork 820
Add bucket index support to store gateway #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bucket index support to store gateway #3625
Conversation
replicaRemovedMeta = "replica-label-removed" | ||
) | ||
|
||
// fetcherMetrics is a copy of Thanos internal fetcherMetrics. These metrics have been copied from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a PR in Thanos thanos-io/thanos#3660 to export the fetcherMetrics
to hopefully remove the duplicated code (even if may be tricky to integrate anyway due to the additional label values corruptedBucketIndex
and noBucketIndex
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b94aae9
to
465b91f
Compare
Compactor block cleaner report an error when directory markers hava a block deletion mark which the block no longer exists.
|
This will result in UpdateIndex always failure. Maybe this should be a warning or just ignored. |
Should be fixed by this change: If, once this PR is merge, it will happen again, then we can re-investigate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, I don't see any flaws in it. Good job!
465b91f
to
6fe30cf
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
cd2f4f6
to
88523e6
Compare
What this PR does:
Following up the PR #3614, in this PR I'm adding bucket index support to the store-gateway. The usage of the bucket index in the store-gateway is optional and disabled by default.
I haven't changed any integration test because the existing tests in
integration/querier_test.go
already covers it.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]