[Querier] Deprecate -querier.compress-http-responses
#3544
Conversation
pkg/cortex/modules.go
Outdated
There was a problem hiding this comment.
If we deprecate removing the code as well we introduce a breaking change (which we can't, I think). We should keep the logic as is, deprecated it in the CLI flag description + CHANGELOG and in 2 minor versions we'll remove it. @gouthamve may you confirm it, please?
There was a problem hiding this comment.
@gotjosh on a related not, does having this flag and the new flag set simultaneously cause an issues? If so you could add a check below to only inject the gzip handler if the query-frontend flag is enabled but not the generic compression flag.
There was a problem hiding this comment.
does having this flag and the new flag set simultaneously cause an issues?
We checked when we reviewed the previuos PR (where the new flag has been introduced) and it shouldn't cause any issue.
pkg/cortex/modules.go
Outdated
There was a problem hiding this comment.
@gotjosh on a related not, does having this flag and the new flag set simultaneously cause an issues? If so you could add a check below to only inject the gzip handler if the query-frontend flag is enabled but not the generic compression flag.
gotjosh
force-pushed
the
depecreate-compression-frontend
branch
from
af266f5 to
572de88
Compare
In favour of `-api.response-compression-enabled` which apply to every other API endpoint we register. Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
depecreate-compression-frontend
branch
from
572de88 to
e0d8400
Compare
Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
depecreate-compression-frontend
branch
from
e0d8400 to
40ac6d7
Compare
bboreham
changed the title
-querier.compress-http-responses-deprecated-querier.compress-http-responses
4 participants
What this PR does:
Deprecate
-querier.compress-http-responses-deprecatedIn favour of-api.response-compression-enabledwhich applies to every other API endpoint we register.Which issue(s) this PR fixes:
A follow up from #3536
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]