Documented how to migrate a live cluster from chunks to blocks #2956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
changed the title
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Good job @pstibrany !
I had a pretty invasive feedback about what should be documented and what not so instead of leaving many small comments I directly committed the changes. See this commit please. If you think the direction is wrong, we can rollback or re-iterate on it. Shortly, what I did:
- This documentation should explain "how to do it" and not "the process we took to realise how to do it"
- Notes about the script should be moved to the script itself (the final user just wanna a working solution and, if doesn't work, can look at the script where they find some notes as code comments)
- For each reconfiguration required, let's give a TL;DR and then a sub-paragraph to explain the "why" of each change
The remaining comments I left apply on top of my changes.
pracucci
reviewed
Aug 3, 2020
pracucci
reviewed
Aug 11, 2020
Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
…igration. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
|
I've addressed your feedback. Please take a look when you have some time. Thank you! |
pracucci
approved these changes
Aug 11, 2020
3 tasks
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds document with some details for migrating existing chunks-based Cortex cluster running in Kubernetes to blocks.
It also shows Jsonnet-based configuration as an example.