Abstract away the interface between the chunk store and DynamoDB #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
changed the title
- Abstract away the specific batch format for dynamodb - Rename DynamoDBClient to StorageClient, generify ListTables, CreateTable, DescribeTables and UpdateTables - Move the provisioning, retries, batching and backoff below the StorageClient interface into the DynamoDB implementation. Also, do a bunch of clean ups: - Remove the dynamovar and s3var, use urlvar instead - Add bunch of comments - Remove semaphore - Rename dynamo_table_manager(_test).go to table_manager(_test).go - Rename dynamodb_test.go to storage_client_mock_test.go, massively simplify - Delete some irrelevant tests; rename some more things - Get rid of stutter in chunk.ChunkStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to be able to support new and exciting backends, such as BigTable or Cassandra.
Introduces a new interface,
StorageClient, which is consumed by theChunkStoreto talk to the index. DynamoDB implementation of this interface does the backoff, batching and retry.Also use this as an opportunity to rename a bunch of stuff for consistency, remove a bunch of old code and generally have a good tidy up.