Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk space requirement in WAL doc #2500

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

codesome
Copy link
Contributor

This is will greatly in planning out the disk space requirement for WAL. The numbers would change a little with #2436, which I will take care in that PR.

/cc @tomwilkie

Copy link
Contributor

@tomwilkie tomwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes.

docs/production/ingesters-with-wal.md Outdated Show resolved Hide resolved
docs/production/ingesters-with-wal.md Outdated Show resolved Hide resolved
docs/production/ingesters-with-wal.md Show resolved Hide resolved
docs/production/ingesters-with-wal.md Outdated Show resolved Hide resolved
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
@pracucci
Copy link
Contributor

@codesome The table rendering is not working fine when building the website:
Screen Shot 2020-04-22 at 17 50 43

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Copy link
Contributor

@codesome I've pushed a commit to fix the table layout for you. Unfortunately you need to also fill the table headers: feel free to rename column titles.

Screen Shot 2020-04-22 at 18 16 13

@pstibrany
Copy link
Contributor

@codesome I've pushed a commit to fix the table layout for you. Unfortunately you need to also fill the table headers: feel free to rename column titles.

Does anything need to be fixed here before merging?

@codesome
Copy link
Contributor Author

@pracucci Thanks for adding the headers!
@pstibrany no changes from my side.

@pstibrany pstibrany merged commit 36496a0 into cortexproject:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants