Skip to content

Remove AWS based autoscaler code #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Remove AWS based autoscaler code #2328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
077d66b
Remove AWS based autoscaler code
gouthamve Mar 25, 2020
2b4d377
Remove unused function.
tomwilkie Mar 28, 2020
6961288
Remove unused vendor code.
tomwilkie Mar 28, 2020
0ecb050
Fix bad rebase.
tomwilkie Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 104 additions & 103 deletions CHANGELOG.md
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions docs/configuration/config-file-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,10 +1361,6 @@ aws:
# CLI flag: -dynamodb.throttle-limit
[throttle_limit: <float> | default = 10]

# ApplicationAutoscaling endpoint URL with escaped Key and Secret encoded.
# CLI flag: -applicationautoscaling.url
[application_autoscaling_url: <url> | default = ]

metrics:
# Use metrics-based autoscaling, via this query URL
# CLI flag: -metrics.url
Expand Down
226 changes: 0 additions & 226 deletions pkg/chunk/aws/aws_autoscaling.go
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions pkg/chunk/aws/dynamodb_storage_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ type DynamoDBConfig struct {
DynamoDB flagext.URLValue `yaml:"dynamodb_url"`
APILimit float64 `yaml:"api_limit"`
ThrottleLimit float64 `yaml:"throttle_limit"`
ApplicationAutoScaling flagext.URLValue `yaml:"application_autoscaling_url"`
Metrics MetricsAutoScalingConfig `yaml:"metrics"`
ChunkGangSize int `yaml:"chunk_gang_size"`
ChunkGetMaxParallelism int `yaml:"chunk_get_max_parallelism"`
Expand All @@ -115,7 +114,6 @@ func (cfg *DynamoDBConfig) RegisterFlags(f *flag.FlagSet) {
"If only region is specified as a host, proper endpoint will be deduced. Use inmemory:///<table-name> to use a mock in-memory implementation.")
f.Float64Var(&cfg.APILimit, "dynamodb.api-limit", 2.0, "DynamoDB table management requests per second limit.")
f.Float64Var(&cfg.ThrottleLimit, "dynamodb.throttle-limit", 10.0, "DynamoDB rate cap to back off when throttled.")
f.Var(&cfg.ApplicationAutoScaling, "applicationautoscaling.url", "ApplicationAutoscaling endpoint URL with escaped Key and Secret encoded.")
f.IntVar(&cfg.ChunkGangSize, "dynamodb.chunk-gang-size", 10, "Number of chunks to group together to parallelise fetches (zero to disable)")
f.IntVar(&cfg.ChunkGetMaxParallelism, "dynamodb.chunk.get-max-parallelism", 32, "Max number of chunk-get operations to start in parallel")
f.DurationVar(&cfg.backoffConfig.MinBackoff, "dynamodb.min-backoff", 100*time.Millisecond, "Minimum backoff time")
Expand Down
7 changes: 0 additions & 7 deletions pkg/chunk/aws/dynamodb_table_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,6 @@ func NewDynamoDBTableClient(cfg DynamoDBConfig) (chunk.TableClient, error) {
}

var autoscale autoscale
if cfg.ApplicationAutoScaling.URL != nil {
autoscale, err = newAWSAutoscale(cfg, callManager)
if err != nil {
return nil, err
}
}

if cfg.Metrics.URL != "" {
autoscale, err = newMetrics(cfg)
if err != nil {
Expand Down
Loading