Added memcached support to the blocks storage index cache #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Good job! Looks like recent readiness probe work from @sandeepsukhani in #2275 comes handy :)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…being stuck Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-Authored-By: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-Authored-By: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-memcached-index-cache-support-for-blocks-storage
branch
from
a8bdbbe to
8e9c601
Compare
pracucci
deleted the
add-memcached-index-cache-support-for-blocks-storage
branch
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…ect/cortex#2290) * Added memcached support to the blocks storage index cache Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Documented blocks storage index cache backends Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed doc Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated doc Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added a timeout to the 'docker inspect' command to avoid the command being stuck Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update integration/e2e/service.go Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-Authored-By: Peter Štibraný <pstibrany@gmail.com> * Update docs/operations/dns-service-discovery.md Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-Authored-By: Peter Štibraný <pstibrany@gmail.com> * Reworded util.StringsContain() comment and params Signed-off-by: Marco Pracucci <marco@pracucci.com> * Separated metrics helpers unit tests using go blocks Signed-off-by: Marco Pracucci <marco@pracucci.com> * Avoid a superfluous querier integration test Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I've added memcached support to the blocks storage index cache.
The PR is quite large due to a refactoring I did in the index cache metrics re-mapping, moving it to the generic storage package. The index cache metrics mapping hasn't changed, while I've added the memcached one.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]