WIP: Support 1w, 1y for retention and table period #2244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
bboreham
reviewed
Mar 10, 2020
| tablePeriod = 7 * 24 * time.Hour | ||
| gracePeriod = 15 * time.Minute | ||
| tablePeriod = model.Duration(7 * 24 * time.Hour) | ||
| gracePeriod = model.Duration(15 * time.Minute) |
There was a problem hiding this comment.
As far as I can see this is always cast to a time.Duration so why not leave it as that?
| @@ -115,9 +115,14 @@ type ProvisionConfig struct { | |||
| func (cfg *TableManagerConfig) RegisterFlags(f *flag.FlagSet) { | |||
| f.BoolVar(&cfg.ThroughputUpdatesDisabled, "table-manager.throughput-updates-disabled", false, "If true, disable all changes to DB capacity") | |||
| f.BoolVar(&cfg.RetentionDeletesEnabled, "table-manager.retention-deletes-enabled", false, "If true, enables retention deletes of DB tables") | |||
| f.DurationVar(&cfg.RetentionPeriod, "table-manager.retention-period", 0, "Tables older than this retention period are deleted. Note: This setting is destructive to data!(default: 0, which disables deletion)") | |||
|
|
|||
| cfg.RetentionPeriod = model.Duration(0) | |||
3 tasks
|
Closing in favor of #2252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us
1win the schema config YAML and also lets us set the retention as2yetc. If this looks good, I'll go ahead and change docs, etc.