Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various things in the build image #2021

Closed
wants to merge 5 commits into from

Conversation

sylr
Copy link

@sylr sylr commented Jan 22, 2020

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@bboreham bboreham changed the title Improve Dockerfile Update various things in the build image Jan 22, 2020
@bboreham
Copy link
Contributor

I changed the title since we have a few "Dockerfile"s

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've published for your the Docker image quay.io/cortexproject/build-image:dockerfile-3860bbe9-WIP based on the updated build-image/Dockerfile. May you rebase master, replace the image URL in .circleci/config.yml and push it, so that we can test if the CI pass?

build-image/Dockerfile Outdated Show resolved Hide resolved
@pracucci
Copy link
Contributor

For the records, the new build-image (dockerfile-3860bbe9-WIP) is 32MB bigger then the current one (validate-k8s-specs-7c217ee7). Not dramatic, but worth to note.

Screen Shot 2020-01-28 at 16 35 09

@pracucci
Copy link
Contributor

I've published for your the Docker image quay.io/cortexproject/build-image:dockerfile-3860bbe9-WIP [...] Can you [...] replace the image URL in .circleci/config.yml and push it, so that we can test if the CI pass?

May you also address this, please?

@sylr
Copy link
Author

sylr commented Mar 6, 2020

@pracucci do you know what should be done to pass CI ?

Sylvain Rabot added 3 commits March 6, 2020 18:22
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@pracucci
Copy link
Contributor

pracucci commented Mar 6, 2020

Let me try to push changes directly to this PR, to contribute to make this PR into a mergeable state.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@gouthamve
Copy link
Contributor

Superseded by #2480

@gouthamve gouthamve closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants