-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various things in the build image #2021
Conversation
I changed the title since we have a few "Dockerfile"s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've published for your the Docker image quay.io/cortexproject/build-image:dockerfile-3860bbe9-WIP
based on the updated build-image/Dockerfile
. May you rebase master
, replace the image URL in .circleci/config.yml
and push it, so that we can test if the CI pass?
May you also address this, please? |
@pracucci do you know what should be done to pass CI ? |
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Let me try to push changes directly to this PR, to contribute to make this PR into a mergeable state. |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Superseded by #2480 |
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]