Limit concurrent replays of TSDB on startup #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
4 times, most recently
from
b8e6ef2 to
fa17e68
Compare
codesome
reviewed
Dec 17, 2019
pracucci
reviewed
Dec 17, 2019
pracucci
reviewed
Dec 17, 2019
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
3 times, most recently
from
266678b to
88317d8
Compare
pracucci
approved these changes
Dec 19, 2019
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
3 times, most recently
from
9f1b1e5 to
9d79340
Compare
codesome
approved these changes
Jan 14, 2020
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
from
9d79340 to
a220652
Compare
|
@thorfour May you fix the failing test, please? |
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
from
a220652 to
126a194
Compare
|
@pracucci should be fixed. |
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
from
126a194 to
214ecbb
Compare
|
@thorfour Other tests are failing now. May you take a look, please? |
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
2 times, most recently
from
a68dc76 to
5c2a5a0
Compare
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
from
5c2a5a0 to
a7f7776
Compare
opening Signed-off-by: Thor <thansen@digitalocean.com>
thorfour
force-pushed
the
feat/tsdb/limit-wal-replay
branch
from
a7f7776 to
e810294
Compare
gouthamve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Experimental TSDB change only. On startup walk the TSDB dir, and open a TSDB under each user dir. Limiting the number of concurrently opening TSDB.
Large memory spikes were observed when Ingesters would startup that had a large number of users with WALs.
This was causing oom kills on ingesters that would otherwise be able to run just fine. This change limits the number of TSDBs that can be opening at once, by opening all pre-existing user TSDBs at startup.
It does not open a TSDB for an empty user dir, which means it has no interaction with a transfer, since transfers delete empty dirs, and error out on non-empty user dirs.
Edit: While this change is still useful it doesn't address the memory usage spikes seen above, and because of a missed lock when looking over the code WAL's weren't being replayed in parallel. WAL replay still eats a large amount of memory regardless of how many are happening in parallel.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]