prefix migrations dir to URI #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
force-pushed
the
20191207_prefix_migrations_dir
branch
from
b705ff1 to
cd57ded
Compare
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
jtlisi
force-pushed
the
20191207_prefix_migrations_dir
branch
from
cd57ded to
e9e5fdf
Compare
bboreham
reviewed
Dec 11, 2019
pkg/configs/db/postgres/postgres.go
Outdated
| i := strings.Index(migrationsDir, ":") | ||
|
|
||
| // Add file scheme if no scheme is present | ||
| if i < 1 { |
There was a problem hiding this comment.
!strings.Contains() is shorter
There was a problem hiding this comment.
I ended up using strings.HasPrefix
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
bboreham
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Ensures the proper file URI scheme for the provided migrations directory.
Which issue(s) this PR fixes:
Fixes #1802 (comment)