Allows to specify a custom interval for splitting and caching frontend requests. #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
changed the title
cyriltovena
force-pushed
the
cache-period
branch
4 times, most recently
from
0bb48b5 to
99e0034
Compare
|
ready for review now that #1734 is merged. |
gouthamve
reviewed
Oct 29, 2019
pracucci
reviewed
Oct 30, 2019
cyriltovena
force-pushed
the
cache-period
branch
from
85d3b07 to
fb25170
Compare
|
Thank you @pracucci an @gouthamve, @jtlisi What do you think ? |
gouthamve
approved these changes
Nov 6, 2019
gouthamve
reviewed
Nov 6, 2019
pracucci
reviewed
Nov 6, 2019
There was a problem hiding this comment.
Good job @cyriltovena! I left a couple of last-minute comments I would be glad you could take a look before the PR will get merged.
cyriltovena
force-pushed
the
cache-period
branch
from
fb25170 to
064f954
Compare
Thanks ! updated. |
pracucci
approved these changes
Nov 7, 2019
gouthamve
approved these changes
Nov 10, 2019
|
Its a shame the split_by_day.go -> split_by_interval.go rename isn't picked up by git, but LGTM. |
tomwilkie
approved these changes
Nov 10, 2019
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
force-pushed
the
cache-period
branch
from
cfa9423 to
b02f0ff
Compare
bboreham
approved these changes
Nov 11, 2019
pkg/querier/queryrange/roundtrip.go
Outdated
| if cfg.SplitQueriesByDay { | ||
| queryRangeMiddleware = append(queryRangeMiddleware, InstrumentMiddleware("split_by_day"), SplitByDayMiddleware(limits, codec)) | ||
| // SplitQueriesByDay is deprecated use SplitQueriesByInterval. | ||
| if cfg.SplitQueriesByDay == true { |
There was a problem hiding this comment.
Could log a warning here, as we do on DeprecatedFlag()
There was a problem hiding this comment.
sure good idea !
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rebased on #1734. I'll rebase it to master once merged to ease review.
/cc @gouthamve @jtlisi