HTTP handler for ingester shutdown #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
gouthamve
reviewed
Oct 23, 2019
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
codesome
force-pushed
the
shutdown-endpoint
branch
from
55d9f38 to
073ed6a
Compare
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
|
Tested it and it works as intended. Ingester goes to LEAVING states, flushes after waiting for other ingesters, and then leaves the ring. I also added another commit to avoid panic on multiple shutdown calls (during graceful shutdown after having called |
gouthamve
approved these changes
Nov 4, 2019
|
Could you add a description of this API to Also it seems worth mentioning in CHANGELOG.md. |
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
|
Needs rebase for changelog conflict now. |
gouthamve
approved these changes
Nov 10, 2019
added 2 commits
November 11, 2019 13:09
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
tomwilkie
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on this design for scaling down using the WAL. This would not block #1103 but this is required for scale downs.
I have yet to verify how it will interact with Kubernetes health checks and pod restarts if the endpoint is hit.