Skip to content

Update build image to golang 1.13 - part 1 #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

Update build image to golang 1.13 - part 1 #1676

merged 1 commit into from
Sep 18, 2019

Conversation

gouthamve
Copy link
Contributor

Needs updation in the circle too. That's after this PR.

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

@gouthamve
Update build image to golang 1.13 - part 1
093e481 
Needs updation in the circle too. That's after this PR.

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
bboreham
bboreham approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved provided Cortex still builds and runs - can't tell from CI tests because they run on the previous image.

@gouthamve
Copy link
Contributor Author

Verified to build. Merging.

@gouthamve gouthamve merged commit 114312d into cortexproject:master Sep 18, 2019
@gouthamve gouthamve deleted the update-1-13-part-1 branch September 18, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

@tomwilkie tomwilkie Awaiting requested review from tomwilkie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouthamve @bboreham