-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tags in manifests #1674
add tags in manifests #1674
Conversation
Thanks for the PR! For background, the existing example manifests were written to aid someone building from source, who would have Also there is a Finally the release instructions should include updating the version. |
Oh, sorry. I missed this Makefile. But I think uses will always try to look at the yamls first instead of Makefile. |
I described some inconsistencies between this PR and other files in the repo. |
I think the version should be v0.3.0 |
The version should be the latest released version, which is why I suggested to add “update the version in the example yamls” to release instructions. |
8930e74
to
4db03ec
Compare
@bboreham Updated. PTAL |
You don’t seem to have addressed any of my comments. Maybe I missed an explanation? |
4db03ec
to
b83480b
Compare
@yeya24 Are you still interested in working on this PR? If yes, may you rebase |
Sure, I will rebase it soon. Could you please give me some hints about how to modify the Makefile? |
What would you like to do specifically? Address Bryan's feedback and add a target to update the version in all K8S spec files? |
Sorry for this delay. |
e19e4d2
to
94f5d78
Compare
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: yeya24 yb532204897@gmail.com
The manifests in /k8s don't have tag in the cortex image, and in quay.io/ortexproject/project there is no tag
latest
. Here add the tag v0.2.0 so users can deploy directly.