Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags in manifests #1674

Merged
merged 3 commits into from
Mar 9, 2020
Merged

add tags in manifests #1674

merged 3 commits into from
Mar 9, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 17, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

The manifests in /k8s don't have tag in the cortex image, and in quay.io/ortexproject/project there is no tag latest. Here add the tag v0.2.0 so users can deploy directly.

@bboreham
Copy link
Contributor

Thanks for the PR!

For background, the existing example manifests were written to aid someone building from source, who would have latest tags, and there were instructions in the README to use them that way. Right now I see no instructions mentioning the manifests, so maybe we should have some?

Also there is a prime-minikube target in the Makefile that is not consistent with changing them to a specific version tag.

Finally the release instructions should include updating the version.

@yeya24
Copy link
Contributor Author

yeya24 commented Sep 18, 2019

Oh, sorry. I missed this Makefile. But I think uses will always try to look at the yamls first instead of Makefile.

@bboreham
Copy link
Contributor

I described some inconsistencies between this PR and other files in the repo.
If you want to fix up those inconsistencies we can proceed.

@anoopl
Copy link

anoopl commented Nov 12, 2019

I think the version should be v0.3.0

@bboreham
Copy link
Contributor

The version should be the latest released version, which is why I suggested to add “update the version in the example yamls” to release instructions.

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 13, 2019

@bboreham Updated. PTAL
Seems there is a flaky test

@bboreham
Copy link
Contributor

You don’t seem to have addressed any of my comments.

Maybe I missed an explanation?

@pracucci
Copy link
Contributor

@yeya24 Are you still interested in working on this PR? If yes, may you rebase master, reiterate on Bryan feedback (see the discussion) and also update the version to v0.6.0 (released today), please?

@yeya24
Copy link
Contributor Author

yeya24 commented Jan 28, 2020

Sure, I will rebase it soon. Could you please give me some hints about how to modify the Makefile?

@pracucci
Copy link
Contributor

Could you please give me some hints about how to modify the Makefile?

What would you like to do specifically? Address Bryan's feedback and add a target to update the version in all K8S spec files?

@yeya24
Copy link
Contributor Author

yeya24 commented Feb 2, 2020

Sorry for this delay.
@bboreham If using specific image tags in manifests, do we still need the targets save-images, load-images, prime-minikube in Makefile? Can I delete them all? Or just delete prime-minikube since I found other save-images and load-images are used in CI

yeya24 and others added 2 commits March 9, 2020 10:14
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit 21d8c91 into cortexproject:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants