Return request data to the pool in Ingester.Push() #1638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1526 the unmarshall code is trying to get memory out of the pool, but in ingesters it is never returned so the
pool.Get()
call just slows things down.After making this change it still wasn't that great, because the pool was boxing
TimeSeries
objects. So change those to*TimeSeries
.before:
after:
(note out of the 3-4MB per iteration, 1MB is overhead from the
FingerprintLocker
)