Update the changelog to reflect recent PRs #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
commented
Aug 23, 2019
CHANGELOG.md
Outdated
| * [CHANGE] Flags changed due to changes upstream in Prometheus Alertmanager #929: | ||
| * `alertmanager.mesh.listen-address` is now `cluster.listen-address` | ||
| * `alertmanager.mesh.peer.host` and `alertmanager.mesh.peer.service` can be replaced by `cluster.peer` | ||
| * `alertmanager.mesh.hardware-address`, `alertmanager.mesh.nickname`, `alertmanager.mesh.password`, and `alertmanager.mesh.peer.refresh-interval` all disappear. | ||
| * [CHANGE] Retention period should now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] The name label for the chunks memcache in all `cortex_cache_` is now `chunksmemcache` (before it was `memcache`) #1569 | ||
| * [FEATURE] Honor https for custom S3 URLs #1603 |
There was a problem hiding this comment.
Though this can be considered a Breaking change too :)
Obligatory xkcd https://xkcd.com/1172/
There was a problem hiding this comment.
We can do breaking changes in 0.x releases.
tomwilkie
reviewed
Aug 23, 2019
CHANGELOG.md
Outdated
| * [CHANGE] Flags changed due to changes upstream in Prometheus Alertmanager #929: | ||
| * `alertmanager.mesh.listen-address` is now `cluster.listen-address` | ||
| * `alertmanager.mesh.peer.host` and `alertmanager.mesh.peer.service` can be replaced by `cluster.peer` | ||
| * `alertmanager.mesh.hardware-address`, `alertmanager.mesh.nickname`, `alertmanager.mesh.password`, and `alertmanager.mesh.peer.refresh-interval` all disappear. | ||
| * [CHANGE] Retention period should now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] The name label for the chunks memcache in all `cortex_cache_` is now `chunksmemcache` (before it was `memcache`) #1569 |
There was a problem hiding this comment.
Suggested change
| * [CHANGE] The name label for the chunks memcache in all `cortex_cache_` is now `chunksmemcache` (before it was `memcache`) #1569 | |
| * [CHANGE] The value for the name label for the chunks memcache in all `cortex_cache_` metrics is now `chunksmemcache` (before it was `memcache`) #1569 |
tomwilkie
approved these changes
Aug 23, 2019
bboreham
approved these changes
Aug 23, 2019
|
Perhaps add something about ingester.spread-flushes being consistent between ingesters? #1578 |
gouthamve
force-pushed
the
update-changelog
branch
3 times, most recently
from
b3c37e8 to
a04c2ac
Compare
CHANGELOG.md
Outdated
| * [CHANGE] Retention period should now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] Retention period must now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] The value for the name name label for the chunks memcache in all `cortex_cache_` metrics is now `chunksmemcache` (before it was `memcache`) #1569 | ||
| * [FEATURE] Makes the ingester flush each timeseries at a specific point in the max-chunk-age cycle. This means multiple replicas of a chunk are very likely to contain the same contents which cuts chunk storage space by up to 66%. |
There was a problem hiding this comment.
The flag should be specifically called out here so that users know the new behavior has to be toggled on.
CHANGELOG.md
Outdated
| * [CHANGE] Flags changed due to changes upstream in Prometheus Alertmanager #929: | ||
| * `alertmanager.mesh.listen-address` is now `cluster.listen-address` | ||
| * `alertmanager.mesh.peer.host` and `alertmanager.mesh.peer.service` can be replaced by `cluster.peer` | ||
| * `alertmanager.mesh.hardware-address`, `alertmanager.mesh.nickname`, `alertmanager.mesh.password`, and `alertmanager.mesh.peer.refresh-interval` all disappear. | ||
| * [CHANGE] Retention period should now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] Retention period must now be a multiple of periodic table duration #1564 | ||
| * [CHANGE] The value for the name name label for the chunks memcache in all `cortex_cache_` metrics is now `chunksmemcache` (before it was `memcache`) #1569 |
gouthamve
force-pushed
the
update-changelog
branch
from
a04c2ac to
879bf00
Compare
Making my life as a release shepherd easy. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-changelog
branch
from
879bf00 to
7d84d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making my life as a release shepherd easy.
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com