20190813 Remove the separate ruler API #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
force-pushed
the
20190813_remove_separate_ruler_api
branch
from
9c83015 to
889d470
Compare
jtlisi
force-pushed
the
20190813_remove_separate_ruler_api
branch
from
889d470 to
49bfd96
Compare
jtlisi
force-pushed
the
20190813_remove_separate_ruler_api
branch
from
49bfd96 to
3259dc7
Compare
khaines
approved these changes
Oct 23, 2019
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> refactor confidb configs and update changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
jtlisi
force-pushed
the
20190813_remove_separate_ruler_api
branch
from
f07a094 to
2be6d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the separate Ruler API. The ruler api is a clone of the config service api. However, it does not currently validate the rules it stores and the postgres config was injected into the client config which made the top level
modules.gofile a bit messier then it needed to be.This removes the current ruler API since there are currently no known users of the api and no plans to improve upon it.