Skip to content

Allow customization of Thanos engine optimizers #6760

Open
@yeya24

Description

@yeya24

Is your feature request related to a problem? Please describe.
Today, we hardcode to enable all optimizers in the Thanos engine https://github.com/cortexproject/cortex/blob/master/pkg/querier/engine_factory.go#L29. However, all optimizers include PropagateMatchersOptimizer which is not a default optimizer.

It might be not ideal to hardcode to enable all optimizers as we may not want to turn off some optimizers for certain usecases.

Describe the solution you'd like
Make thanos engine optimizers configurable. It can be a list of optimizers to enable. We can have special values such as all or default which enables pre-setoptimizers.
This can also be used to enable more optimizers maybe specific to Cortex in the future.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions