Skip to content

Disable chunk trimming in Ingesters #6269

Closed
@yeya24

Description

@yeya24

Is your feature request related to a problem? Please describe.
Similar to thanos-io/thanos#7815

If the requested time range is within the range of a chunk, then if chunks trimming enabled, Ingesters spend CPU decoding chunks and throw away samples that outside the requested time range.

This step is actually unnecessary because the query engine already drops samples that outside the requested time range so the CPU time spent on decoding chunks is wasted.

Describe the solution you'd like
Similar to thanos-io/thanos#7815, disable chunk trimming in the select hints in Ingester.

Additional context
It would be good to add a fuzzy (promqlsmith) tests to make sure disabling chunk trimming doesn't change query results.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions