Skip to content

Add missing tsdb head metrics to ingesters #5623

Closed
@yeya24

Description

@yeya24

Is your feature request related to a problem? Please describe.
More TSDB head metrics have been added in upstream Prometheus https://github.com/prometheus/prometheus/blob/main/tsdb/head.go#L320.

We should consider add them to existing ingester metrics https://github.com/cortexproject/cortex/blob/master/pkg/ingester/metrics.go#L237.

Some metrics are very useful to have such as prometheus_tsdb_head_out_of_order_samples_appended_total and prometheus_tsdb_out_of_order_samples_total to help troubleshoot samples OOO issue.

Describe the solution you'd like
Update https://github.com/cortexproject/cortex/blob/master/pkg/ingester/metrics.go#L237 code to add missing ingester metrics.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions