make memberlist kvstore to default

[songjiayang]

Is your feature request related to a problem? Please describe.

currently the ring kvstore default value is consul, how about changing it to memberlist.

[alvinlin123]

I think this idea is worth the discussing. What pros and cons do you think changing the default would have?

For me the cons is it would be a breaking change? Pros is better out-of-box experience ( no need to deploy extra service out-of-box).

[songjiayang]

Frankly speaking, this is indeed a break change. but when we want to use consul, we must configure consul_config, eg the address, so in fact, only a few people did not set store to consule.

if memberlist is default, we can use common memberlist_config, configuration will be more simpler.

memberlist isn't default:

memberlist:
  join_members: [cortex-1, cortex-2, cortex-3]

ingester:
  lifecycler:
    ring:
      kvstore:
        store: memberlist

store_gateway:
  sharding_enabled: true
  sharding_ring:
    kvstore:
      store: memberlist

ruler:
  enable_api: true
  enable_sharding: true
  poll_interval: 2s
  ring:
    kvstore:
      store: memberlist

memberlist is default:

memberlist:
  join_members: [cortex-1, cortex-2, cortex-3]

store_gateway:
  sharding_enabled: true

ruler:
  enable_api: true
  enable_sharding: true
  poll_interval: 2s

[yeya24]

+1 to this change. I love the out of box experience and memberlist should be good enough for most of the users.

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[wgliang]

Will this continue to move forward?

[alanprot]

I think make sense to change it to default!

Im afraid about the breaking change indeed.. we may break customer on next release if they did not explicitly configure this? Even though i think its unlikely that we configure the other consul config but not the type.

[wgliang]

I think we can start by supporting optional use of memberlist, and as for changing the default, we can transition to a later version.

[wgliang]

To some extent, customers do not want to have external dependencies (Etcd...risk) in production environments.
We are way behind the other one project in some aspects, you know what I mean.

[yeya24]

If we want to change it anyway then there is breaking change for sure so I am not concerned about breaking customers. I think I am ok to change memberlist as the default.

That being said, there is nothing blocking this change. It is always welcome to create a PR to Cortex if this is the feature you are looking for.

[alanprot]

I think we can start by supporting optional use of memberlist, and as for changing the default, we can transition to a later version.

Cortex already support memberlist.