cannot set -ingester.chunk-encoding by config file

[Wing924]

The -ingester.chunk-encoding can only set by flag and it can't be set by config file.

cortex/pkg/chunk/encoding/factory.go

Lines 16 to 28 in 4e2dd12

	var (
	// DefaultEncoding exported for use in unit tests elsewhere
	DefaultEncoding = DoubleDelta
	alwaysMarshalFullsizeChunks = true
	bigchunkSizeCapBytes = 0
	)
	// RegisterFlags registers configuration settings.
	func (Config) RegisterFlags(f *flag.FlagSet) {
	f.Var(&DefaultEncoding, "ingester.chunk-encoding", "Encoding version to use for chunks.")
	flag.BoolVar(&alwaysMarshalFullsizeChunks, "store.fullsize-chunks", alwaysMarshalFullsizeChunks, "When saving varbit chunks, pad to 1024 bytes")
	flag.IntVar(&bigchunkSizeCapBytes, "store.bigchunk-size-cap-bytes", bigchunkSizeCapBytes, "When using bigchunk encoding, start a new bigchunk if over this size (0 = unlimited)")
	}

[pracucci]

True. I believe it's not a trivial change to do because DefaultEncoding is a global variable and not bind to a config struct. If you have a good idea to add YAML config in a safe and clean way, I would love to review that PR.

[tomwilkie]

Would love to be able to do this from the config file - any ideas?

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[pracucci]

Still valid

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[pracucci]

Still valid

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[pracucci]

Still valid, but we need some help