Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental auth-gateway #474

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

friedrichg
Copy link
Member

What this PR does: Add experimental auth-gateway

Which issue(s) this PR fixes:
Fixes cortexproject/auth-gateway#33

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
@friedrichg
Copy link
Member Author

disabled by default, but I need to add a test file for this

@nschad
Copy link
Collaborator

nschad commented Aug 1, 2023

disabled by default, but I need to add a test file for this

Cool. Some default values are also missing, right? Like image repo, tag etc.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@ron1
Copy link

ron1 commented Jan 5, 2024

What else is needed to get this PR merged?

@stale stale bot removed the stale label Jan 5, 2024
@johnk9283
Copy link

Would love to see this work continued still!

@ncauchois
Copy link

I would love to see this work continue too !

@nschad
Copy link
Collaborator

nschad commented Oct 15, 2024

Update @friedrichg ?

          image: "{{ .Values.auth_gateway.image.repository }}:{{ .Values.auth_gateway.image.tag }}"

What image should the user use? Bring your own?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

How to use auth-gateway in K8s
6 participants