Skip to content

Cortex 1.9 Adjustments #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 4, 2021
Merged

Cortex 1.9 Adjustments #154

merged 7 commits into from
Jun 4, 2021

Conversation

ts-mini
Copy link
Contributor

@ts-mini ts-mini commented May 27, 2021

Based on some deprecations in the release notes for 1.9 this should help solve: #153

@ts-mini ts-mini marked this pull request as ready for review May 27, 2021 19:01
@ts-mini ts-mini force-pushed the tsmini.1-9-adjustments branch from fbc42ea to 846427d Compare May 27, 2021 19:13
@cabrinha
Copy link
Collaborator

@ts-mini maybe you could try adding @khaines as a reviewer?

@khaines
Copy link
Contributor

khaines commented May 30, 2021

@ts-mini @cabrinha - Unfortunately, I'm no longer a maintainer for the cortex project org (lack of time). I don't have the permission access to merge this. Please raise this in the #cortex slack channel as needing review & merge.

overall it looks good to me since it's a straightforward change.

nschad
nschad reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but unsure about enabling api response compression by default

@nschad nschad mentioned this pull request Jun 3, 2021
Closed
@cabrinha cabrinha mentioned this pull request Jun 3, 2021
Closed
@nschad
Copy link
Contributor

nschad commented Jun 3, 2021

@ts-mini Can you please update the CHANGELOG.md under the master / unreleased section?

[ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

ts-mini added 5 commits June 4, 2021 09:38
@ts-mini
Adjusting values for cortexproject/cortex#4101
a3d4045 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@ts-mini
fixing per: cortexproject/cortex#4101
f643ba5 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@ts-mini
this goes in limits
97abda7 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@ts-mini
Adjusting alert manager statefulset config for 1.9
ad2207e 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@ts-mini
Adding changelog
f7fda54 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@ts-mini ts-mini force-pushed the tsmini.1-9-adjustments branch from c6eef04 to f7fda54 Compare June 4, 2021 15:40
@ts-mini ts-mini requested review from nschad and cabrinha June 4, 2021 15:41
nschad
nschad reviewed Jun 4, 2021
View reviewed changes
@ts-mini
I passed an english class once upon a time
87d79be 
Signed-off-by: Tyler Horvath <tyler.horvath@gmail.com>
@nschad nschad merged commit 8745b57 into cortexproject:master Jun 4, 2021
This was referenced Jun 6, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschad nschad nschad approved these changes

@cabrinha cabrinha Awaiting requested review from cabrinha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ts-mini @cabrinha @khaines @nschad