-
Notifications
You must be signed in to change notification settings - Fork 606
added rolling update to deamonset #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tthebst thank you for your contribution, this is awesome! I'm glad you were able to get the development workflow set up; although we've tried to document it clearly, it's definitely not a simple process. Feel free to reach out on gitter (https://gitter.im/cortexlabs/cortex) or GitHub issues if you have any questions or run into any issues.
I reviewed the PR, and left a few comments. I'll await your responses, and I plan on testing it out on my end either tomorrow or early next week.
Lastly, do you mind signing the CLA?
Thanks again for your work on this! I think we'll be able to get it in for our next release (we're planning on cutting the release candidate mid to end next week).
@tthebst Thanks for addressing my comments! I'll try this out on my end soon, and then I'll merge it in. |
@deliahu Thank you for your feedback. These are my first real contributions to an opensource project. I like the project and will try to find some good other addressable issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for your contribution!
@tthebst sounds great! All of the features/improvements/bugs that are on our radar are listed in our GitHub Project. That list may be a bit overwhelming, so (as you probably noticed when you searched for this issue) we have created the "good first issue" label and added it to some of our issues. That said, the other ones are all fair game too, and some of them may be good first issues as well - we plan on making a pass on all of our issues and seeing if we can add the label to more of them. Feel free to let us know which ones sound interesting to you. We'd be able to advise on which one might be best to start with based on your interests and the scope of the task, as well as point you in the right direction (since some of our descriptions are vague and and some of our issues need additional design thought). |
updated cloudwatch-agent-statsd, fluentd and nvidia to perform rolling update in cluster update command.
closes #630
checklist:
make test
andmake lint
summary.md
(view in gitbook after merging)