Skip to content

Improve cluster error messages #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Improve cluster error messages #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cli/cmd/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ var _upCmd = &cobra.Command{
exit.Error(err)
}
if exitCode == nil || *exitCode != 0 {
fmt.Printf("additional information may be found in the activity history of your cluster's autoscaling groups https://console.aws.amazon.com/ec2/autoscaling/home?region=%s#AutoScalingGroups:\n", *clusterConfig.Region)
fmt.Println("\nDebugging tips (may not apply to this error):")
fmt.Printf("* if your cluster started to spin up but was unable to provision instances, additional error information may be found in the activity history of your cluster's autoscaling groups (select each autoscaling group and click the \"Activity History\" tab): https://console.aws.amazon.com/ec2/autoscaling/home?region=%s#AutoScalingGroups:\n", *clusterConfig.Region)
fmt.Printf("* if your cluster started spinning up, please ensure that your CloudFormation stacks for this cluster have been fully deleted before trying to spin up this cluster again: https://console.aws.amazon.com/cloudformation/home?region=%s#/stacks?filteringText=-%s-\n", *clusterConfig.Region, clusterConfig.ClusterName)
exit.ErrorNoPrint(out)
}
},
Expand Down Expand Up @@ -128,7 +130,8 @@ var _updateCmd = &cobra.Command{
exit.Error(err)
}
if exitCode == nil || *exitCode != 0 {
fmt.Printf("additional information may be found in the activity history of your cluster's autoscaling groups https://console.aws.amazon.com/ec2/autoscaling/home?region=%s#AutoScalingGroups:\n", *clusterConfig.Region)
fmt.Println("\nDebugging tips (may not apply to this error):")
fmt.Printf("* if your cluster was unable to provision instances, additional error information may be found in the activity history of your cluster's autoscaling groups (select each autoscaling group and click the \"Activity History\" tab): https://console.aws.amazon.com/ec2/autoscaling/home?region=%s#AutoScalingGroups:\n", *clusterConfig.Region)
exit.ErrorNoPrint(out)
}
},
Expand Down Expand Up @@ -239,6 +242,7 @@ var _downCmd = &cobra.Command{
exit.Error(err)
}
if exitCode == nil || *exitCode != 0 {
fmt.Printf("\nNote: if this error cannot be resolved, please ensure that all CloudFormation stacks for this cluster eventually become been fully deleted (https://console.aws.amazon.com/cloudformation/home?region=%s#/stacks?filteringText=-%s-). If the stack deletion process has failed, please manually delete the stack from the AWS console (this may require manually deleting particular AWS resources that are blocking the stack deletion)\n", *accessConfig.Region, *accessConfig.ClusterName)
exit.ErrorNoPrint(out)
}

Expand Down
2 changes: 1 addition & 1 deletion manager/uninstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ echo -e "spinning down the cluster ...\n"

eksctl delete cluster --name=$CORTEX_CLUSTER_NAME --region=$CORTEX_REGION --timeout=$EKSCTL_TIMEOUT

echo -e "\n✓ please check cloudformation to ensure that all resources for the ${CORTEX_CLUSTER_NAME} cluster are successfully deleted: https://${CORTEX_REGION}.console.aws.amazon.com/cloudformation"
echo -e "\n✓ please check CloudFormation to ensure that all resources for the ${CORTEX_CLUSTER_NAME} cluster eventually become successfully deleted: https://console.aws.amazon.com/cloudformation/home?region=${CORTEX_REGION}#/stacks?filteringText=-${CORTEX_CLUSTER_NAME}-"