Skip to content

Align vertically #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Align vertically #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions cli/cmd/get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,23 +388,6 @@ func classificationMetricsTable(apiMetrics schema.APIMetrics) string {
}
sort.Strings(classList)

if len(classList) > 0 && len(classList) < 4 {
row := []interface{}{}
headers := []table.Header{}

for _, className := range classList {
headers = append(headers, table.Header{Title: s.TruncateEllipses(className, 20), MaxWidth: 20})
row = append(row, apiMetrics.ClassDistribution[className])
}

t := table.Table{
Headers: headers,
Rows: [][]interface{}{row},
}

return table.MustFormat(t)
}

rows := make([][]interface{}, len(classList))
for rowNum, className := range classList {
rows[rowNum] = []interface{}{
Expand Down
2 changes: 1 addition & 1 deletion pkg/consts/consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ var (

TelemetryURL = "https://telemetry.cortexlabs.dev"

MaxClassesPerRequest = 75 // cloudwatch.GeMetricData can get up to 100 metrics per request, avoid multiple requests and have room for other stats
MaxClassesPerRequest = 20 // cloudwatch.GeMetricData can get up to 100 metrics per request, avoid multiple requests and have room for other stats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this have to drop to 20? We can discuss tomorrow

)