Support model directories on S3 #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospillinger
approved these changes
Aug 14, 2019
deliahu
reviewed
Aug 14, 2019
deliahu
reviewed
Aug 15, 2019
deliahu
reviewed
Aug 16, 2019
| for root, dirs, files in os.walk(path): | ||
| for name in files: | ||
| objects.append(os.path.join(root, name)) | ||
| for name in dirs: |
There was a problem hiding this comment.
I don't think the S3 version of list_objects() returns directories, just objects. Can you confirm, and if so, only return files here?
added 3 commits
August 19, 2019 00:35
deliahu
reviewed
Aug 19, 2019
deliahu
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
Checklist:
make testandmake lintcx refresh)summary.md)