Skip to content

Allow specifying ranges in cortex requirements.txt #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2019
Merged

Allow specifying ranges in cortex requirements.txt #32

merged 3 commits into from
Mar 11, 2019

Conversation

vishalbollu
Copy link
Contributor

Checklist:

  • Run automated tests (make test)
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Add license header to each new file
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested review from 1vn and deliahu March 7, 2019 20:23
@CLAassistant
Copy link

CLAassistant commented Mar 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

1vn
1vn reviewed Mar 7, 2019
View reviewed changes
1vn
1vn approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deliahu
deliahu approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalbollu vishalbollu merged commit a14a2eb into master Mar 11, 2019
@vishalbollu vishalbollu deleted the flexible-requirements branch March 12, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

+1 more reviewer

@1vn 1vn 1vn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vishalbollu @CLAassistant @deliahu @1vn