Skip to content

Fix exception when creating Python client without default env set #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Fix exception when creating Python client without default env set #2225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix exception when creating Python client without default env set
  • Loading branch information
@deliahu
deliahu committed Jun 4, 2021
commit d55d404cda59316d1afb41e7b38849d315d2b14c
4 changes: 0 additions & 4 deletions cli/cmd/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ var _envListCmd = &cobra.Command{
}

if _flagOutput == flags.JSONOutputType {
if len(cliConfig.Environments) == 0 {
fmt.Print("[]")
return
}
bytes, err := libjson.Marshal(cliConfig.ConvertToUserFacingCLIConfig())
if err != nil {
exit.Error(err)
Expand Down
6 changes: 5 additions & 1 deletion cli/types/cliconfig/cli_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,12 @@ func (cliConfig *CLIConfig) Validate() error {
}

func (cliConfig *CLIConfig) ConvertToUserFacingCLIConfig() UserFacingCLIConfig {
envs := cliConfig.Environments
if envs == nil {
envs = []*Environment{}
}
return UserFacingCLIConfig{
DefaultEnvironment: cliConfig.DefaultEnvironment,
Environments: cliConfig.Environments,
Environments: envs,
}
}