Add readiness/liveness probes to k8s CaaS resources #2187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deliahu
reviewed
May 20, 2021
miguelvr
changed the title
miguelvr
reviewed
May 21, 2021
RobertLucian
changed the title
deliahu
reviewed
May 21, 2021
deliahu
approved these changes
May 22, 2021
miguelvr
reviewed
May 24, 2021
| @@ -62,6 +62,7 @@ type StringValidation struct { | |||
| CastScalar bool | |||
| AllowCortexResources bool | |||
| RequireCortexResources bool | |||
| DockerImage bool | |||
There was a problem hiding this comment.
what is this for? user container image? In any case, I think it needs a better naming scheme, since docker is a company
There was a problem hiding this comment.
It checks whether it's a valid docker image registry path. We can do this in a separate PR as this is a literal copy-paste from the other configreader validations.
miguelvr
reviewed
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checklist:
make testandmake lint