Skip to content

Allow using images from other accounts and regions #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Mar 29, 2021

closes #1988

Operator and worker instances now have the same access. Users can attach polices to enable their cluster to access images from other ecr accounts and regions. This PR removes image validations that prevents users from accessing images from other regions and accounts.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobertLucian RobertLucian merged commit 27ae401 into master Mar 29, 2021
@RobertLucian RobertLucian deleted the remove-outdated-ecr-image-validations branch March 29, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the use of any ECR images that the AWS account has access to
2 participants