Skip to content

Delayed queue deletion #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 15, 2021
Merged

Delayed queue deletion #1952

merged 6 commits into from
Mar 15, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Mar 12, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

miguelvr
miguelvr approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to get more insight on the if statement regarding the queue tags

@vishalbollu vishalbollu merged commit c50f8aa into master Mar 15, 2021
@vishalbollu vishalbollu deleted the delayed-queue-deletion branch March 15, 2021 19:47
@vishalbollu vishalbollu added this to the 0.31 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

@deliahu deliahu Awaiting requested review from deliahu

@RobertLucian RobertLucian Awaiting requested review from RobertLucian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.31
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @miguelvr