Skip to content

Add support for multi-instance-type clusters to AWS/GCP providers #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Mar 15, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Mar 12, 2021

Benefits of the MITC functionality

  1. Lower costs: Compared to single-instance-type clusters, reduces overall compute costs by using the most economical instance for the given workloads.
  2. Simpler logistics: User no longer has to manage multiple clusters on their own.
  3. Multi-purpose cluster: The cluster can now take any range of workloads. One cluster for everything (CPUs, GPUs, Inferentia). Just throw a bunch of node groups in the cluster config, and you’re set.

Example config

cluster_name: cortex
provider: aws
region: us-west-2

node_groups:
  - instance_type: t3.medium
    max_instances: 5
    min_instances: 200
  - instance_type: c5.xlarge
    min_instances: 5
    max_instances: 100
  - instance_type: g4dn.xlarge
    min_instances: 0
    max_instances: 100
    spot: true
  - instance_type: g4dn.xlarge
    min_instances: 0
    max_instances: 100
  - instance_type: inf1.xlarge
    min_instances: 0
    max_instances: 100

checklist:

  • run make test and make lint
  • update .circleci config
  • test manually (i.e. test cluster(-gcp) commands, multiple node groups/pools, cpu/gpu/inferentia workloads in single cluster, etc)

@RobertLucian RobertLucian added the enhancement New feature or request label Mar 12, 2021
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Mostly nits. Can be merged after name field is set to required, memory map is tested.

@RobertLucian RobertLucian merged commit 010221f into master Mar 15, 2021
@RobertLucian RobertLucian deleted the feature/multi-instance-type-clusters branch March 15, 2021 20:50
@vishalbollu vishalbollu added this to the 0.31 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants