Skip to content

Increase buffer size for logs to address unexpected log stream termination #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 5, 2021
Merged

Increase buffer size for logs to address unexpected log stream termination #1939

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
175223e
Update workload_logging.go
vishalbollu Mar 5, 2021
666ad0e
Update comments
vishalbollu Mar 5, 2021
de78c91
Merge branch 'master' into fix-cx-logs-unexpected-termination
RobertLucian Mar 5, 2021
0e4c527
Update workload_logging.go
vishalbollu Mar 5, 2021
e22f248
Update workload_logging.go
vishalbollu Mar 5, 2021
5ef0d05
Update workload_logging.go
vishalbollu Mar 5, 2021
af193ab
Update workload_logging.go
vishalbollu Mar 5, 2021
2cdb392
Merge branch 'master' into fix-cx-logs-unexpected-termination
RobertLucian Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/operator/operator/workload_logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ func startKubectlProcess(podName string, cancelListener chan struct{}, socket *w
}

func pumpStdout(socket *websocket.Conn, reader io.Reader) {
// it seems like if the buffer is maxed out with no ending token, the scanner just exits.
// increase the buffer used by the scanner to accommodate larger log lines (a common issue when printing progress)
p := make([]byte, 1024*1024)
scanner := bufio.NewScanner(reader)
scanner.Buffer(p, 1024*1024)
for scanner.Scan() {
logBytes := scanner.Bytes()
var message jsonMessage
Expand Down