Skip to content

Determine job status based on k8s job and fix pointer bug #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2021
Merged

Determine job status based on k8s job and fix pointer bug #1917

merged 5 commits into from
Mar 1, 2021

Conversation

vishalbollu
Copy link
Contributor

  • Determine job status based on kubernetes job before checking queue metrics
  • Fix bug in crons where all job ids mapped to the last k8s job due to a pointer derefernce bug in for loop

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

RobertLucian
RobertLucian reviewed Mar 1, 2021
View reviewed changes
@vishalbollu vishalbollu merged commit 28ba9a9 into master Mar 1, 2021
@vishalbollu vishalbollu deleted the job-status-based-on-k8s-job branch March 1, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

@miguelvr miguelvr Awaiting requested review from miguelvr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @RobertLucian